lkml.org 
[lkml]   [2024]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5.10 005/238] btrfs: add and use helper to check if block group is used
    Hi!

    > > From: Filipe Manana <fdmanana@suse.com>
    > >
    > > [ Upstream commit 1693d5442c458ae8d5b0d58463b873cd879569ed ]
    > >
    > > Add a helper function to determine if a block group is being used and make
    > > use of it at btrfs_delete_unused_bgs(). This helper will also be used in
    > > future code changes.
    > >
    > > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
    > > Reviewed-by: Josef Bacik <josef@toxicpanda.com>
    > > Reviewed-by: Boris Burkov <boris@bur.io>
    > > Signed-off-by: Filipe Manana <fdmanana@suse.com>
    > > Reviewed-by: David Sterba <dsterba@suse.com>
    > > Signed-off-by: David Sterba <dsterba@suse.com>
    > > Signed-off-by: Sasha Levin <sashal@kernel.org>
    >
    > Please drop this patch from all stable branches unless it's a
    > prerequisite for some other patch. This is clearly a cleanup.

    This was reported multiple times, and you have even said you have
    dropped the patch. What went wrong here?

    Best regards,
    Pavel

    Date: Mon, 18 Mar 2024 10:18:36 -0400
    From: Sasha Levin <sashal@kernel.org>
    Subject: Re: [PATCH AUTOSEL 5.10 1/7] btrfs: add and use helper to check if block group is used

    On Mon, Mar 11, 2024 at 10:05:40PM +0100, David Sterba wrote:
    > On Mon, Mar 11, 2024 at 10:00:43PM +0100, Pavel Machek wrote:
    > > Hi!
    > >
    > > > From: Filipe Manana <fdmanana@suse.com>
    > > >
    > > > [ Upstream commit 1693d5442c458ae8d5b0d58463b873cd879569ed ]
    > > >
    > > > Add a helper function to determine if a block group is being used and make
    > > > use of it at btrfs_delete_unused_bgs(). This helper will also be used in
    > > > future code changes.
    > >
    > > Does not fix a bug and does not seem to be preparation for anything,
    > > so probably should not be here.
    >
    > Agreed, this patch does not belong to stable and I objected in
    > https://lore.kernel.org/all/20240229155207.GA2604@suse.cz/
    >
    > for version 6.7 and all other stable versions.

    Dropped, thanks!

    --
    Thanks,
    Sasha

    --
    DENX Software Engineering GmbH, Managing Director: Erika Unter
    HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2024-05-27 16:13    [W:4.503 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site