Messages in this thread | | | Date | Thu, 28 Mar 2024 11:18:51 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH 1/2] drm/qxl: remove unused `count` variable from `qxl_surface_id_alloc()` |
| |
On Wed, Mar 27, 2024 at 07:14:12PM +0100, Miguel Ojeda wrote: > On Wed, Mar 27, 2024 at 6:56 PM Miguel Ojeda <ojeda@kernel.org> wrote: > > > > Closes: https://lore.kernel.org/lkml/CANiq72mjc5t4n25SQvYSrOEhxxpXYPZ4pPzneSJHEnc3qApu2Q@mail.gmail.com/ > > Should have a [1] at the end.
I added it while committing
> > Signed-off-by: Miguel Ojeda <ojeda@kernel.org> > > --- > > Given there is a loop going on here, it would be good to double-check whether > > this variable was supposed to be used for something useful or if it was just a > > remnant of a version previous to v1.4. > > Also, I see Nathan sent meanwhile a message about these two that were > also mentioned/reported a while ago [1].
"a while ago" here being 2 hours before your message :)
I've added a Closes tag for that report too.
I've applied both patches to drm-misc-fixes, thanks! Maxime [unhandled content-type:application/pgp-signature] | |