Messages in this thread | | | Date | Thu, 28 Mar 2024 18:13:26 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH v6 3/5] crypto: tegra: Add Tegra Security Engine driver |
| |
On Tue, Mar 19, 2024 at 01:53:04PM +0530, Akhil R wrote: > > +struct tegra_sha_reqctx { > + struct ahash_request fallback_req;
This doesn't work because ahash_request is dynamically sized. So you'll end up clobbering the rest of the struct if a fallback ends up being used.
You should place the fallback_req at the end of the reqctx and set the reqsize based on the fallback reqsize.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |