Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 28 Mar 2024 10:30:27 +0100 | Subject | Re: [PATCH v2 3/7] dt-bindings: hsi: omap-ssi: convert to YAML | From | Krzysztof Kozlowski <> |
| |
On 27/03/2024 20:11, Sebastian Reichel wrote: > Convert the legacy txt binding to modern YAML. > There are a couple of semantic changes: > - hsi-port@<addr> and ssi-port@<addr> node name > changed to port@<addr> > - ti,hwmods was marked as deprecated. This is supposed to go away > once OMAP3 gets the same treatment as OMAP4. > - changed ti,cawake-gpio to ti,cawake-gpios > - describe peripheral requirements for the port node > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> ..
> + > + interrupt-names: > + const: gdd_mpu > + > + ti,hwmods: > + const: ssi > + deprecated: true > + > +patternProperties: > + "port@[0-9a-f]+":
Missing ^ and $.
> + type: object > + additionalProperties: false > + > + properties: > + compatible: > + enum: > + - ti,omap3-ssi-port > + - ti,omap4-hsi-port > + > + reg: > + items: > + - description: TX registers > + - description: RX registers > + > + reg-names: > + items: > + - const: tx > + - const: rx > + > + interrupts: > + items: > + - description: MPU interrupt 0 > + - description: MPU interrupt 1 > + minItems: 1 > + > + ti,ssi-cawake-gpios: > + description: GPIO signifying CAWAKE events > + maxItems: 1 > + > + patternProperties: > + "^(modem|mcu)$": > + type: object
additionalProperties: true (I think I mentioned it last time)
> + $ref: /schemas/hsi/hsi-client.yaml# > + > + required: > + - compatible > + - reg > + - reg-names > + - interrupts > + > +required: > + - compatible > + - reg > + - reg-names > + - ranges > + - "#address-cells" > + - "#size-cells" > + - clocks > + - clock-names > + - interrupts > + - interrupt-names
Rest looks good, thanks. With these two changes:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| ![\](/images/icornerr.gif) |