Messages in this thread | | | Date | Thu, 28 Mar 2024 10:07:51 +0100 | From | Neil Armstrong <> | Subject | Re: [PATCH RESEND v6 0/5] spmi: pmic-arb: Add support for multiple buses |
| |
Hi Abel,
On 26/03/2024 17:28, Abel Vesa wrote: > This RFC prepares for and adds support for 2 buses, which is supported > in HW starting with version 7. Until now, none of the currently > supported platforms in upstream have used the second bus. The X1E80100 > platform, on the other hand, needs the second bus for the USB2.0 to work > as there are 3 SMB2360 PMICs which provide eUSB2 repeaters and they are > all found on the second bus.
@Dmitry, @Konrad, @Bjorn, could you apply those patches and test an devices you have to make sure there's no regression ?
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > Changes in v6: > - Changed the compatible to platform specific (X1E80100) along with the > schema. Fixed the spmi buses unit addresses and added the empty ranges > property. Added missing properties to the spmi buses and the > "unevaluatedProperties: false". > - Deprecated the "qcom,bus-id" in the legacy schema. > - Changed the driver to check for legacy compatible first > - Link to v5: https://lore.kernel.org/r/20240221-spmi-multi-master-support-v5-0-3255ca413a0b@linaro.org > > Changes in v5: > - Dropped the RFC as there aren't any concerns about the approach anymore > - Dropped the unused dev and res variables from pmic_arb_get_obsrvr_chnls_v2 > - Link to v4: https://lore.kernel.org/r/20240220-spmi-multi-master-support-v4-0-dc813c878ba8@linaro.org > > Changes in v4: > - Fixed comment above pmic_arb_init_apid_v7 by dropping the extra "bus" word > - Swicthed to devm_platform_ioremap_resource_byname for obsrvr and chnls. > The core remains with platform_get_resource_byname as we need the core size. > - Dropped comment from probe related to the need of platform_get_resource_byname > as it not true anymore. > - Dropped the qcom,bus-id optional property. > - Link to v3: https://lore.kernel.org/r/20240214-spmi-multi-master-support-v3-0-0bae0ef04faf@linaro.org > > Changes in v3: > - Split the change into 3 separate patches. First 2 patches are moving > apid init and core resources into version specific ops. Third one is > adding the support for 2 buses and dedicated compatible. > - Added separate bindings patch > - Link to v2: https://lore.kernel.org/r/20240213-spmi-multi-master-support-v2-1-b3b102326906@linaro.org > > Changes in v2: > - Reworked it so that it registers a spmi controller for each bus > rather than relying on the generic framework to pass on the bus > (master) id. > - Link to v1: https://lore.kernel.org/r/20240207-spmi-multi-master-support-v1-0-ce57f301c7fd@linaro.org > > --- > Abel Vesa (5): > dt-bindings: spmi: Add X1E80100 SPMI PMIC ARB schema > dt-bindings: spmi: Deprecate qcom,bus-id
Forgot to add, but please fix this in a v7:
> spmi: pmic-arb: Make the APID init a version operation
drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core_size' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'mapping_table_valid' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:243: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_read_data' drivers/spmi/spmi-pmic-arb.c:257: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_write_data'
> spmi: pmic-arb: Make core resources acquiring a version operation
drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core_size' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'mapping_table_valid' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:222: warning: Function parameter or struct member 'get_core_resources' not described in 'pmic_arb_ver_ops' drivers/spmi/spmi-pmic-arb.c:244: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_read_data' drivers/spmi/spmi-pmic-arb.c:258: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_write_data'
> spmi: pmic-arb: Add multi bus support > > .../bindings/spmi/qcom,spmi-pmic-arb.yaml | 1 + > .../bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml | 136 +++ > drivers/spmi/spmi-pmic-arb.c | 948 +++++++++++++-------- > 3 files changed, 715 insertions(+), 370 deletions(-) > --- > base-commit: 4893c639cc3659cefaa675bf1e59f4e7571afb5c > change-id: 20240207-spmi-multi-master-support-832a704b779b > > Best regards,
Thanks, Neil
| |