Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 28 Mar 2024 09:54:13 +0100 | Subject | Re: [PATCH v3] gpio: cdev: sanitize the label before requesting the interrupt |
| |
On Mon, Mar 25, 2024 at 10:02 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > When an interrupt is requested, a procfs directory is created under > "/proc/irq/<irqnum>/<label>" where <label> is the string passed to one of > the request_irq() variants. > > What follows is that the string must not contain the "/" character or > the procfs mkdir operation will fail. We don't have such constraints for > GPIO consumer labels which are used verbatim as interrupt labels for > GPIO irqs. We must therefore sanitize the consumer string before > requesting the interrupt. > > Let's replace all "/" with ":". > > Cc: stable@vger.kernel.org > Reported-by: Stefan Wahren <wahrenst@gmx.net> > Closes: https://lore.kernel.org/linux-gpio/39fe95cb-aa83-4b8b-8cab-63947a726754@gmx.net/ > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Good work on this one! Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |