Messages in this thread | | | Subject | Re: [PATCH 17/23] dt-bindings: media: imx258: Rename to include vendor prefix | From | Kieran Bingham <> | Date | Thu, 28 Mar 2024 08:52:01 +0000 |
| |
Quoting git@luigi311.com (2024-03-28 00:57:34) > On 3/27/24 17:47, Conor Dooley wrote: > > On Wed, Mar 27, 2024 at 05:17:03PM -0600, git@luigi311.com wrote: > >> From: Dave Stevenson <dave.stevenson@raspberrypi.com> > >> > >> imx258.yaml doesn't include the vendor prefix of sony, so > >> rename to add it. > >> Update the id entry and MAINTAINERS to match. > >> > >> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > >> Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > This is a v1 with my ack, something has gone awry here. It's also > > missing your signoff. Did you pick up someone else's series? > > Yes, this is a continuation of Dave's work. I contacted him directly, > and he mentioned that he is unable to submit a v2 any time soon and > was open to someone else continuing it in his stead. This is my first > time submitting a patch via a mailing list, so I'm not sure if I'm > missing something, but I only added my sign off for anything that > actually included work from my side and not just bringing his patch > forward to this patch series.
Your cover letter states v2, but the individual patches do not.
Add the '-v2' (or, rather, next it will be '-v3') to git format-patch when you save your series and it will add the version to each patch. You can also add '-s' to that command I believe to add your SoB to each patch.
-- Kieran
> > > > >> --- > >> .../bindings/media/i2c/{imx258.yaml => sony,imx258.yaml} | 2 +- > >> MAINTAINERS | 2 +- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > >> rename Documentation/devicetree/bindings/media/i2c/{imx258.yaml => sony,imx258.yaml} (97%) > >> > >> diff --git a/Documentation/devicetree/bindings/media/i2c/imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > >> similarity index 97% > >> rename from Documentation/devicetree/bindings/media/i2c/imx258.yaml > >> rename to Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > >> index 80d24220baa0..bee61a443b23 100644 > >> --- a/Documentation/devicetree/bindings/media/i2c/imx258.yaml > >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > >> @@ -1,7 +1,7 @@ > >> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> %YAML 1.2 > >> --- > >> -$id: http://devicetree.org/schemas/media/i2c/imx258.yaml# > >> +$id: http://devicetree.org/schemas/media/i2c/sony,imx258.yaml# > >> $schema: http://devicetree.org/meta-schemas/core.yaml# > >> > >> title: Sony IMX258 13 Mpixel CMOS Digital Image Sensor > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index aa3b947fb080..1f17f6734bf5 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -20464,7 +20464,7 @@ M: Sakari Ailus <sakari.ailus@linux.intel.com> > >> L: linux-media@vger.kernel.org > >> S: Maintained > >> T: git git://linuxtv.org/media_tree.git > >> -F: Documentation/devicetree/bindings/media/i2c/imx258.yaml > >> +F: Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > >> F: drivers/media/i2c/imx258.c > >> > >> SONY IMX274 SENSOR DRIVER > >> -- > >> 2.42.0 > >> >
| |