lkml.org 
[lkml]   [2024]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    Subject[PATCH v4 2/2] tracing: Include Microcode Revision in mce_record tracepoint
    From


    On 3/27/2024 17:35, Borislav Petkov wrote:
    > On Wed, Mar 27, 2024 at 03:31:01PM -0700, Sohil Mehta wrote:
    >> On 3/27/2024 1:54 PM, Avadhut Naik wrote:
    >>
    >>> - TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN: %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC: %x",
    >>> + TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN: %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC: %x, MICROCODE REVISION: %x",
    >>
    >> Nit: s/MICROCODE REVISION/MICROCODE/g
    >>
    >> You could probably get rid of the word REVISION in the interest of
    >> brevity similar to __print_mce().
    >
    > You *definitely* want to do that - good catch.
    >
    Will do.

    > And TBH, all the screaming words aren't helping either... :)
    >
    Are you suggesting to change the ALL CAPS format of words which are
    not acronyms to normal Capitalization style? Like Sohit suggested
    in his other mail on this thread?

    Somewhat like below:

    SOCKET -> Socket
    PROCESSOR -> Processor
    MICROCODE -> Microcode

    --
    Thanks,
    Avadhut Naik

    \
     
     \ /
      Last update: 2024-03-28 07:17    [W:4.177 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site