Messages in this thread | | | From | Norihiko Hama <> | Subject | RE: [PATCH] usb-storage: Optimize scan delay more precisely | Date | Thu, 28 Mar 2024 23:38:37 +0000 |
| |
> > > Here's an approach that Greg might accept. > > > > > > Since we already have a delay_use module parameter, we could add a > > > delay_use_ms parameter. The two module parameters would display the > > > same value, but delay_use_ms would be in milliseconds instead of in > > > seconds. (This is similar to what we did for the autosuspend and > > > autosuspend_delay_ms sysfs attributes.) > > > > What about just changing the parser on the currently delay_use > > parameter to accept an optional suffix? If it's just digits, it is in > > seconds. If it ends in "ms", then interpret it as milliseconds. This > > would be backwards compatible with existing uses, give you the > > flexibility you want, avoid adding another modules parameter, and > > potentially be expandable in the future (if, for some reason, someone > > wanted microseconds or kiloseconds). > > A little unconventional, I think (at least, I don't know offhand of any other module parameters or sysfs attributes that work this way), but it would work. > > Noriko, would you like to write a patch to do this?
Thank you for your advice. I understand and will try to do that.
Best regards, Norihiko Hama
| |