Messages in this thread | | | Date | Thu, 28 Mar 2024 18:05:41 +0000 | From | Conor Dooley <> | Subject | Re: [PATCH v1 1/4] dt-bindings: input: Add Himax HX83102J touchscreen |
| |
On Thu, Mar 28, 2024 at 02:05:17PM +0800, Allen Lin wrote:
> OK, I will list all supplies required by the driver in the Yaml > document as shown below, > > properties: > compatible: > const: himax,hx83102j > > reg: > maxItems: 1 > > interrupts: > maxItems: 1 > > reset-gpios: > maxItems: 1 > > vccd-supply: > description: A phandle for the regualtor supplying IO power. > > vsn-supply: > description: Negative supply regulator. > > vsp-supply: > description: Positive supply regulator. > > ddreset-gpios:
I think this should be s/dd// with the description explaining how this display reset is related to this device.
Otherwise, this looks okay to me.
On another note - every time you reply to me I get it 3 times. Can you fix that please?
Thanks, Conor.
> description: A phandle of gpio for display reset controlled by the > LCD driver. > > required: > - compatible > - reg > - interrupts > - reset-gpios > - panel > - vccd-supply > - vsn-supply > - vsp-supply > - ddreset-gpios > > > Thanks, > Allen > [unhandled content-type:application/pgp-signature] | |