Messages in this thread | | | Date | Thu, 28 Mar 2024 11:03:23 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH RFC 1/7] regulator: devres: add APIs for reference supplies |
| |
On Wed, Mar 27, 2024 at 06:18:50PM -0500, David Lechner wrote: > A common use case for regulators is to supply a reference voltage to an > analog input or output device. This adds two new devres APIs to get, > enable, and get the voltage in a single call. This allows eliminating > boilerplate code in drivers that use reference supplies in this way. > > devm_regulator_get_enable_get_voltage() is intended for cases where the > supply is required to provide an external reference voltage. > > devm_regulator_get_optional_enable_get_voltage() is intended for cases > where the supply is optional and device typically uses an internal > reference voltage if the supply is not available.
So because we decided that we could not have devm_regulator_enable() because of (IMO) contrived example of someone totally mixing up the devm and non-devm APIs we now have to make more and more devm- variants simply because we do not have access to the regulator structure with devm_regulator_get_enable() and so all normal APIs are not available.
This is quite bad honestly. Mark, could we please reverse this shortsighted decision and have normal devm_regulator_enable() operating on a regulator?
Thanks.
-- Dmitry
| |