Messages in this thread Patch in this message | | | From | Shawn Sung (宋孝謙) <> | Subject | Re: [PATCH v6 04/14] drm/mediatek: Add DRM_MODE_ROTATE_0 to rotation property | Date | Thu, 28 Mar 2024 02:50:32 +0000 |
| |
Hi CK,
On Mon, 2024-03-25 at 01:52 +0000, CK Hu (胡俊光) wrote: > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > > > b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > > > index 0ebeaf9830d83..2a767a823c83a 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > > > @@ -288,6 +288,10 @@ unsigned int mtk_ovl_layer_nr(struct device > > > *dev) > > > > > > unsigned int mtk_ovl_supported_rotations(struct device *dev) > > > { > > > + /* > > > + * although currently OVL can only do reflection, > > > + * reflect x + reflect y = rotate 180 > > > + */ > > Sorry, this comment is not related to DRM_MODE_ROTATE_0, so after > removing this comment, > > Reviewed-by: CK Hu <ck.hu@mediatek.com> >
Got it. No problem. Will remove it from this series.
Thanks, Shawn
| |