lkml.org 
[lkml]   [2024]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] platform/x86/amd/hsmp: switch to use device_add_groups()
On Wed, 27 Mar 2024, Greg Kroah-Hartman wrote:

> devm_device_add_groups() is being removed from the kernel, so move the
> hsmp driver to use device_add_groups() instead. The logic is identical,
> when the device is removed the driver core will properly clean up and
> remove the groups, and the memory used by the attribute groups will be
> freed because it was created with dev_* calls, so this is functionally
> identical overall.
>
> Cc: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
> Cc: Carlos Bilbao <carlos.bilbao@amd.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
> Cc: platform-driver-x86@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> v3: change the changelog text to reflect that this change is identical
> to the current code. Rebase against 6.9-rc1
> v2: rebased against platform/for-next
>
> drivers/platform/x86/amd/hsmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/hsmp.c
> index 1927be901108..d84ea66eecc6 100644
> --- a/drivers/platform/x86/amd/hsmp.c
> +++ b/drivers/platform/x86/amd/hsmp.c
> @@ -693,7 +693,7 @@ static int hsmp_create_non_acpi_sysfs_if(struct device *dev)
> hsmp_create_attr_list(attr_grp, dev, i);
> }
>
> - return devm_device_add_groups(dev, hsmp_attr_grps);
> + return device_add_groups(dev, hsmp_attr_grps);
> }
>
> static int hsmp_create_acpi_sysfs_if(struct device *dev)

Thanks for the update.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
i.
\
 
 \ /
  Last update: 2024-05-27 16:11    [W:0.050 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site