Messages in this thread | | | Date | Wed, 27 Mar 2024 11:36:17 +0100 | Subject | Re: [PATCH v2 1/4] power: supply: mm8013: fix "not charging" detection | From | Hans de Goede <> |
| |
Hi,
On 3/3/24 4:31 PM, Thomas Weißschuh wrote: > The charge_behaviours property is meant as a control-knob that can be > changed by the user. > > Page 23 of [0] which documents the flag CHG_INH as follows: > > CHG_INH : Charge Inhibit When the current is more than or equal to charge > threshold current, > charge inhibit temperature (upper/lower limit) :1 > charge permission temperature or the current is > less than charge threshold current :0 > > So this is pure read-only information which is better represented as > POWER_SUPPLY_STATUS_NOT_CHARGING. > > [0] https://product.minebeamitsumi.com/en/product/category/ics/battery/fuel_gauge/parts/download/__icsFiles/afieldfile/2023/07/12/1_download_01_12.pdf > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> --- > drivers/power/supply/mm8013.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/power/supply/mm8013.c b/drivers/power/supply/mm8013.c > index caa272b03564..20c1651ca38e 100644 > --- a/drivers/power/supply/mm8013.c > +++ b/drivers/power/supply/mm8013.c > @@ -71,7 +71,6 @@ static int mm8013_checkdevice(struct mm8013_chip *chip) > > static enum power_supply_property mm8013_battery_props[] = { > POWER_SUPPLY_PROP_CAPACITY, > - POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR, > POWER_SUPPLY_PROP_CHARGE_FULL, > POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN, > POWER_SUPPLY_PROP_CHARGE_NOW, > @@ -103,16 +102,6 @@ static int mm8013_get_property(struct power_supply *psy, > > val->intval = regval; > break; > - case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR: > - ret = regmap_read(chip->regmap, REG_FLAGS, ®val); > - if (ret < 0) > - return ret; > - > - if (regval & MM8013_FLAG_CHG_INH) > - val->intval = POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE; > - else > - val->intval = POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO; > - break; > case POWER_SUPPLY_PROP_CHARGE_FULL: > ret = regmap_read(chip->regmap, REG_FULL_CHARGE_CAPACITY, ®val); > if (ret < 0) > @@ -187,6 +176,8 @@ static int mm8013_get_property(struct power_supply *psy, > > if (regval & MM8013_FLAG_DSG) > val->intval = POWER_SUPPLY_STATUS_DISCHARGING; > + else if (regval & MM8013_FLAG_CHG_INH) > + val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING; > else if (regval & MM8013_FLAG_CHG) > val->intval = POWER_SUPPLY_STATUS_CHARGING; > else if (regval & MM8013_FLAG_FC) >
| |