Messages in this thread | | | Date | Wed, 27 Mar 2024 11:46:19 +0300 | From | arinc.unal@arinc9 ... | Subject | Re: [PATCH net v2 2/2] net: dsa: mt7530: fix disabling EEE on failure on MT7531 and MT7988 |
| |
On 26.03.2024 12:19, Arınç ÜNAL wrote: > On 26.03.2024 12:02, Paolo Abeni wrote: >> If I read the past discussion correctly, this is a potential issue >> found by code inspection and never producing problem in practice, am I >> correct? >> >> If so I think it will deserve a 3rd party tested-by tag or similar to >> go in. >> >> If nobody could provide such feedback in a little time, I suggest to >> drop this patch and apply only 1/2. > > Whether a problem would happen in practice depends on when > phy_init_eee() > fails, meaning it returns a negative non-zero code. I requested Russell > to > review this patch to shed light on when phy_init_eee() would return a > negative non-zero code so we have an idea whether this patch actually > fixes > a problem.
I don't suppose Russell is going to review the patch at this point. I will submit this to net-next then. If someone actually reports a problem in practice, I can always submit it to the stable trees.
Arınç
| |