lkml.org 
[lkml]   [2024]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net v2 2/2] net: dsa: mt7530: fix disabling EEE on failure on MT7531 and MT7988
On 26.03.2024 12:19, Arınç ÜNAL wrote:
> On 26.03.2024 12:02, Paolo Abeni wrote:
>> If I read the past discussion correctly, this is a potential issue
>> found by code inspection and never producing problem in practice, am I
>> correct?
>>
>> If so I think it will deserve a 3rd party tested-by tag or similar to
>> go in.
>>
>> If nobody could provide such feedback in a little time, I suggest to
>> drop this patch and apply only 1/2.
>
> Whether a problem would happen in practice depends on when
> phy_init_eee()
> fails, meaning it returns a negative non-zero code. I requested Russell
> to
> review this patch to shed light on when phy_init_eee() would return a
> negative non-zero code so we have an idea whether this patch actually
> fixes
> a problem.

I don't suppose Russell is going to review the patch at this point. I
will
submit this to net-next then. If someone actually reports a problem in
practice, I can always submit it to the stable trees.

Arınç

\
 
 \ /
  Last update: 2024-05-27 16:10    [W:0.123 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site