Messages in this thread | | | Date | Wed, 27 Mar 2024 09:44:21 +0100 | Subject | Re: [PATCH v4 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support | From | Krzysztof Kozlowski <> |
| |
On 26/03/2024 21:56, Konrad Dybcio wrote: > On 25.03.2024 7:16 PM, Odelu Kukatla wrote: >> It adds QoS support for QNOC device and includes support for >> configuring priority, priority forward disable, urgency forwarding. >> This helps in priortizing the traffic originating from different >> interconnect masters at NoC(Network On Chip). >> >> Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com> >> --- > > [...] > >> >> + if (desc->config) { >> + struct resource *res; >> + void __iomem *base; >> + >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> + if (!res) >> + goto skip_qos_config; >> + >> + base = devm_ioremap_resource(dev, res); > > You were asked to substitute this call like 3 times already.. > > devm_platform_get_and_ioremap_resource > > or even better, devm_platform_ioremap_resource
Yeah, I wonder what else from my feedback got ignored :(
Best regards, Krzysztof
| |