Messages in this thread | | | Date | Wed, 27 Mar 2024 20:08:54 -0400 | From | Paul Moore <> | Subject | Re: [PATCH] selinux: use u32 as bit type in ebitmap code |
| |
On Mar 15, 2024 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@googlemail.com> wrote: > > The extensible bitmap supports bit positions up to U32_MAX due to the > type of the member highbit being u32. Use u32 consistently as the type > for bit positions to announce to callers what range of values is > supported. > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> > --- > v4: > - apply format style > I hope i addressed all comment from [1] in [2]. > v3: > - revert type change of unrelated iter variable > - use U32_MAX instead of (u32)-1 > v2: avoid declarations in init-clauses of for loops > > [1]: https://lore.kernel.org/selinux/67cee6245e2895e81a0177c4c1ed01ba.paul@paul-moore.com/ > [2]: https://lore.kernel.org/selinux/CAJ2a_DdLR40CB6Ua5cNjYhtexNmGkzQRsVrJn+dhVaZO-aVKsA@mail.gmail.com/ > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> > --- > security/selinux/ss/ebitmap.c | 31 +++++++++++++++------------- > security/selinux/ss/ebitmap.h | 38 ++++++++++++++++------------------- > 2 files changed, 34 insertions(+), 35 deletions(-)
Merged into selinux/dev, thanks for following up on this.
-- paul-moore.com
| |