Messages in this thread | | | Date | Wed, 27 Mar 2024 21:03:38 +0100 | Subject | Re: [PATCH v11] platform/x86: add lenovo wmi camera button driver | From | Hans de Goede <> |
| |
Hi,
On 3/27/24 2:14 PM, Andy Shevchenko wrote: > On Wed, Mar 27, 2024 at 11:54:55AM +0100, Hans de Goede wrote: >> On 3/26/24 3:54 AM, 艾超 wrote: > > ... > >>>>> +config LENOVO_WMI_CAMERA >>>>> + tristate "Lenovo WMI Camera Button driver" >>>>> + depends on ACPI_WMI >>>>> + depends on INPUT >>> >>>> No COMPILE_TEST? >>> >>> I compile this driver and used Evtest tool to test it on lenovo A70. > > What I meant here is to add respective COMPILE_TEST to the dependency(ies).
Neither include/linux/input.h nor include/linux/wmi.h offer stubs when disabled so this will not work.
Besides x86 has a lot of compile test coverage in general, so I don't see much value in adding || COMPILE_TEST to dependencies.
Regards,
Hans
| |