Messages in this thread | | | From | Subbaraya Sundeep Bhatta <> | Subject | RE: [EXTERNAL] [PATCH 3/9] qed: avoid truncating work queue length | Date | Wed, 27 Mar 2024 17:08:21 +0000 |
| |
Hi,
>-----Original Message----- >From: Arnd Bergmann <arnd@arndb.de> >Sent: Wednesday, March 27, 2024 9:05 PM >To: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>; Arnd Bergmann ><arnd@kernel.org>; llvm@lists.linux.dev; Ariel Elior <aelior@marvell.com>; >Manish Chopra <manishc@marvell.com> >Cc: David S . Miller <davem@davemloft.net>; Eric Dumazet ><edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni ><pabeni@redhat.com>; Nathan Chancellor <nathan@kernel.org>; Nick >Desaulniers <ndesaulniers@google.com>; Bill Wendling <morbo@google.com>; >Justin Stitt <justinstitt@google.com>; Simon Horman <horms@kernel.org>; >Konstantin Khorenko <khorenko@virtuozzo.com>; Sudarsana Reddy Kalluru ><sudarsana.kalluru@cavium.com>; Netdev <netdev@vger.kernel.org>; linux- >kernel@vger.kernel.org >Subject: Re: [EXTERNAL] [PATCH 3/9] qed: avoid truncating work queue length > >On Wed, Mar 27, 2024, at 15:04, Subbaraya Sundeep Bhatta wrote: > >>>- snprintf(name, NAME_SIZE, "slowpath-%02x:%02x.%02x", >>>- cdev->pdev->bus->number, >>>- PCI_SLOT(cdev->pdev->devfn), hwfn->abs_pf_id); >>>+ hwfn->slowpath_wq = alloc_workqueue("slowpath- >>>%02x:%02x.%02x", >>>+ 0, 0, cdev->pdev->bus->number, >>>+ PCI_SLOT(cdev->pdev->devfn), >>>+ hwfn->abs_pf_id); >> >> Confused. This should be alloc_workqueue("slowpath-%02x:%02x.%02x", >> cdev->pdev->bus->number, PCI_SLOT(cdev->pdev->devfn), hwfn->abs_pf_id, >> 0, 0); >> Right? > >I still think my version is the right one here, see the >prototype: > >__printf(1, 4) struct workqueue_struct * >alloc_workqueue(const char *fmt, unsigned int flags, int max_active, ...); > >so the first argument in the format, while the printf arguments >start after the flags and max_active arguments that are still both >set to zero. > My bad. Got it
Thanks, Sundeep
> Arnd
| |