Messages in this thread | | | Date | Wed, 27 Mar 2024 10:17:37 -0600 | Subject | Re: [PATCH 1/2] selftests: x86: test_vsyscall: conform test to TAP format output | From | Shuah Khan <> |
| |
On 3/27/24 06:16, Muhammad Usama Anjum wrote: > On 3/27/24 1:00 AM, Shuah Khan wrote: >> On 3/14/24 04:32, Muhammad Usama Anjum wrote: >>> Conform the layout, informational and status messages to TAP. No >>> functional change is intended other than the layout of output messages. >>> Without using TAP messages, the passed/failed/skip test names cannot be >>> found. >>> >>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> >>> --- >> >> >> I am seeing lot more changes than conform and formatting changes. > Counting total number of tests based on architecture was really difficult > until the code needed to be moved around. I'll split this patch into 2. The > first part would just simplify the test by moving functions around and use > #ifdef precisely. The seconds part would convert it to the TAP. >
Yes. That will make is easier to review and maintain.
thanks, -- Shuah
| |