Messages in this thread | | | Date | Wed, 27 Mar 2024 16:47:36 +0100 | Subject | Re: [PATCH RFC 0/3] mm/gup: consistently call it GUP-fast | From | David Hildenbrand <> |
| |
On 27.03.24 16:46, Ryan Roberts wrote: >> >> Some of them look like mm-unstable issue, For example, arm64 fails with >> >> CC arch/arm64/mm/extable.o >> In file included from ./include/linux/hugetlb.h:828, >> from security/commoncap.c:19: >> ./arch/arm64/include/asm/hugetlb.h:25:34: error: redefinition of >> 'arch_clear_hugetlb_flags' >> 25 | #define arch_clear_hugetlb_flags arch_clear_hugetlb_flags >> | ^~~~~~~~~~~~~~~~~~~~~~~~ >> ./include/linux/hugetlb.h:840:20: note: in expansion of macro >> 'arch_clear_hugetlb_flags' >> 840 | static inline void arch_clear_hugetlb_flags(struct folio *folio) { } >> | ^~~~~~~~~~~~~~~~~~~~~~~~ >> ./arch/arm64/include/asm/hugetlb.h:21:20: note: previous definition of >> 'arch_clear_hugetlb_flags' with t >> ype 'void(struct folio *)' >> 21 | static inline void arch_clear_hugetlb_flags(struct folio *folio) >> | ^~~~~~~~~~~~~~~~~~~~~~~~ >> In file included from ./include/linux/hugetlb.h:828, >> from mm/filemap.c:37: >> ./arch/arm64/include/asm/hugetlb.h:25:34: error: redefinition of >> 'arch_clear_hugetlb_flags' >> 25 | #define arch_clear_hugetlb_flags arch_clear_hugetlb_flags >> | ^~~~~~~~~~~~~~~~~~~~~~~~ >> ./include/linux/hugetlb.h:840:20: note: in expansion of macro >> 'arch_clear_hugetlb_flags' >> 840 | static inline void arch_clear_hugetlb_flags(struct folio *folio) { } >> | ^~~~~~~~~~~~~~~~~~~~~~~~ >> ./arch/arm64/include/asm/hugetlb.h:21:20: note: previous definition of >> 'arch_clear_hugetlb_flags' with type 'void(struct folio *)' >> 21 | static inline void arch_clear_hugetlb_flags(struct folio *folio) > > see: https://lore.kernel.org/linux-mm/ZgQvNKGdlDkwhQEX@casper.infradead.org/ >
Yes, besides the other failures I see (odd targets), I was expecting that someone else noticed that already :) thanks!
-- Cheers,
David / dhildenb
| |