lkml.org 
[lkml]   [2024]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/7] riscv: Simplify text patching loops
From
Hi David,

On 2024-02-19 4:13 PM, David Laight wrote:
> ...
>>> - while (patched < len && !ret) {
>>> - size = min_t(size_t, PAGE_SIZE * 2 - offset_in_page(addr + patched), len - patched);
>>> - ret = __patch_insn_set(addr + patched, c, size);
>>> + while (len && !ret) {
>>> + size = min_t(size_t, PAGE_SIZE * 2 - offset_in_page(addr), len);
>
> Does that need to be min_t()?
> Both arguments seem to be unsigned.
> (Did it even ever need to be?)

You're right, this never needed min_t(). I'll update this for v2.

Regards,
Samuel


\
 
 \ /
  Last update: 2024-05-27 16:12    [W:0.065 / U:24.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site