Messages in this thread | | | Date | Wed, 27 Mar 2024 05:40:10 -0700 | Subject | Re: [PATCH net v5] net: txgbe: fix i2c dev name cannot match clkdev | From | Florian Fainelli <> |
| |
On 3/26/2024 6:29 PM, duanqiangwen@net-swift.com wrote: >> -----Original Message----- >> From: Jiri Pirko <jiri@resnulli.us> >> Sent: 2024年3月22日 16:12 >> To: Duanqiang Wen <duanqiangwen@net-swift.com> >> Cc: netdev@vger.kernel.org; jiawenwu@trustnetic.com; >> mengyuanlou@net-swift.com; davem@davemloft.net; >> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >> maciej.fijalkowski@intel.com; andrew@lunn.ch; >> wangxiongfeng2@huawei.com; linux-kernel@vger.kernel.org; >> michal.kubiak@intel.com >> Subject: Re: [PATCH net v5] net: txgbe: fix i2c dev name cannot match > clkdev >> >> Fri, Mar 22, 2024 at 09:04:16AM CET, duanqiangwen@net-swift.com wrote: >>> txgbe clkdev shortened clk_name, so i2c_dev info_name also need to >>> shorten. Otherwise, i2c_dev cannot initialize clock. >>> >>> Change log: >>> v4-v5: address comments: >>> Jiri Pirko: >>> Well, since it is used in txgbe_phy.c, it should be probably >>> rather defined locally in txgbe_phy.c. >> >> Did you read Florian's comment? Please do. >> >> pw-bot: cr >> > > I replied to Florian: > " I want to shorten "i2c_desginware" to "i2c_dw" in txgbe driver, so other > drivers which use "i2c_designware" need another patch to use a define. " > > He hasn't replied to me for several days, what should I do next?
You emailed me directly rather than do a reply-all and have the mailing list copied. At any rate, you are only changing your internal clock name, so my suggestion to standardize the 'i2c_designware' string beyond your driver did not really make sense.
With that:
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Thanks! -- Florian
| |