lkml.org 
[lkml]   [2024]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/4] firmware: qcom: scm: Remove log reporting memory allocation failure
    Date
    Remove redundant memory allocation failure.

    WARNING: Possible unnecessary 'out of memory' message
    + if (!mdata_buf) {
    + dev_err(__scm->dev, "Allocation of metadata buffer failed.\n");

    Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
    Reviewed-by: Bjorn Andersson <andersson@kernel.org>
    ---
    Changes in v2: https://lore.kernel.org/lkml/20240227155308.18395-7-quic_mojha@quicinc.com/
    - Added R-by tag

    drivers/firmware/qcom/qcom_scm.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
    index 49ddbcab0680..a11fb063cc67 100644
    --- a/drivers/firmware/qcom/qcom_scm.c
    +++ b/drivers/firmware/qcom/qcom_scm.c
    @@ -554,10 +554,9 @@ int qcom_scm_pas_init_image(u32 peripheral, const void *metadata, size_t size,
    */
    mdata_buf = dma_alloc_coherent(__scm->dev, size, &mdata_phys,
    GFP_KERNEL);
    - if (!mdata_buf) {
    - dev_err(__scm->dev, "Allocation of metadata buffer failed.\n");
    + if (!mdata_buf)
    return -ENOMEM;
    - }
    +
    memcpy(mdata_buf, metadata, size);

    ret = qcom_scm_clk_enable();
    --
    2.7.4

    \
     
     \ /
      Last update: 2024-05-27 15:58    [W:4.028 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site