Messages in this thread | | | Date | Thu, 21 Mar 2024 06:48:31 -0700 | From | Nathan Chancellor <> | Subject | Re: [GIT PULL] Char/Misc driver changes for 6.9-rc1 |
| |
On Thu, Mar 21, 2024 at 02:02:19PM +0100, Greg KH wrote: > All of these have been in linux-next for a long time with no reported > issue, other than a build warning with some older versions of gcc for a > speakup driver, fix for that will come in a few days when I catch up > with my pending patch queues. .. > Samuel Thibault (2): > speakup: Fix 8bit characters from direct synth > speakup: Add /dev/synthu device
That build warning actually happens with clang, not GCC as far as I am aware, and it is actually a hard build error with older versions of clang, as Arnd points out in his patch to fix this (although the warning is a hard error with CONFIG_WERROR too, which causes allmodconfig to break):
https://lore.kernel.org/20240313100413.875280-1-arnd@kernel.org/
Samuel's patch was even simpler:
https://lore.kernel.org/20240309203549.jj2l6epnznyjsrje@begin/
Why was one of these changes not applied before this was sent? I am aware you were on vacation recently but you are now adding a known issue to -rc1, which can proliferate to other maintainer's trees and makes testing for us more difficult :/ -next has been broken for the entire merge window over this, which is usually when there is a chance we can get maybe a week of green builds...
Cheers, Nathan
| |