Messages in this thread | | | Date | Thu, 21 Mar 2024 10:59:35 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] reset: gpio: Fix missing gpiolib dependency for GPIO reset controller |
| |
On Thu, Mar 21, 2024 at 08:18:36AM +0100, Krzysztof Kozlowski wrote: > On 20/03/2024 20:59, Mark Brown wrote:
> > The GPIO reset controller uses gpiolib but there is no Kconfig > > dependency reflecting this fact, add one.
> Lack of dependency was intentional: because there is no dependency. > GPIOLIB is optional. Because of that I added few stubs for missing > GPIOLIB functions, but I missed this stub here.
> I propose to add gpio_device_find_by_fwnode() stub for !GPIOLIB case, > instead of adding dependency.
In general the stubs do make sense however in this specific case given that the driver is specifically to control a GPIO rather than using a GPIO along with controlling some other thing a dependency does seem like it makes sense. [unhandled content-type:application/pgp-signature] | |