Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Thu, 21 Mar 2024 10:48:29 +0000 | Subject | Re: [PATCH v3 3/4] dt-bindings: serial: renesas,scif: Document R9A09G057 support |
| |
Hi Rob,
Thank you for the review.
On Wed, Mar 20, 2024 at 2:37 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, Mar 18, 2024 at 05:21:01PM +0000, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Document support for the Serial Communication Interface with FIFO (SCIF) > > available in the Renesas RZ/V2H(P) (R9A09G057) SoC. The SCIF interface in > > the Renesas RZ/V2H(P) is similar to that available in the RZ/G2L > > (R9A07G044) SoC, with the only difference being that the RZ/V2H(P) SoC has > > three additional interrupts: one for Tx end/Rx ready and the other two for > > Rx and Tx buffer full, which are edge-triggered. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > v2->v3 > > - Added SoC specific compat string > > --- > > .../bindings/serial/renesas,scif.yaml | 33 +++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > index 53f18e9810fd..e4ce13e20cd7 100644 > > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > @@ -79,6 +79,8 @@ properties: > > - renesas,scif-r9a08g045 # RZ/G3S > > - const: renesas,scif-r9a07g044 # RZ/G2{L,LC} fallback > > > > + - const: renesas,scif-r9a09g057 # RZ/V2H(P) > > I don't understand why there's not a fallback. Looks like the existing > driver would work if you had one. It should be fine to ignore the new > interrupts. Though with Geert's comments, it seems there are more > differences than you say. > Apart from the interrupt differences there are some register bit differences too (as pointed by Geert in patch 4/4).
Cheers, Prabhakar
| |