lkml.org 
[lkml]   [2024]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ata: ahci_ceva: return of_property_read_u8_array() error code
From
> In the ahci_ceva_probe() error path instead of returning -EINVAL for all
> of_property_read_u8_array() failure types return the actual error code.
> It removes the redundant -EINVAL assignment at multiple places and
> improves the error handling path.

A) Would a change description be more desirable with a corresponding imperative wording?

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.8#n94


B) Can it be helpful to specify the hint “in ceva_ahci_probe()” at the end
of the patch subject?


C) How do you think about to extend the application of scope-based resource management here?

See also:
Article by Jonathan Corbet
2023-06-15
https://lwn.net/Articles/934679/


Regards,
Markus

\
 
 \ /
  Last update: 2024-05-27 15:57    [W:0.047 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site