lkml.org 
[lkml]   [2024]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] fs: aio: use a folio in aio_setup_ring()
From


On 2024/3/21 16:27, Kefeng Wang wrote:
> Use a folio throughout aio_setup_ring() to remove calls to compound_head().
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> fs/aio.c | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index 9cdaa2faa536..d7f6c8705016 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -527,17 +527,20 @@ static int aio_setup_ring(struct kioctx *ctx, unsigned int nr_events)
> }
>
> for (i = 0; i < nr_pages; i++) {
> - struct page *page;
> - page = find_or_create_page(file->f_mapping,
> - i, GFP_USER | __GFP_ZERO);
> - if (!page)
> + struct folio *folio;
> +
> + folio = __filemap_get_folio(file->f_mapping, i,
> + FGP_LOCK | FGP_ACCESSED | FGP_CREAT,
> + GFP_USER | __GFP_ZERO);
> + if (!folio)
Oh, this should be if (IS_ERR(folio)), will update.

> break;
> - pr_debug("pid(%d) page[%d]->count=%d\n",
> - current->pid, i, page_count(page));
> - SetPageUptodate(page);
> - unlock_page(page);
>
> - ctx->ring_pages[i] = page;
> + pr_debug("pid(%d) [%d] folio->count=%d\n", current->pid, i,
> + folio_ref_count(folio));
> + folio_mark_uptodate(folio);
> + folio_unlock(folio);
> +
> + ctx->ring_pages[i] = &folio->page;
> }
> ctx->nr_pages = i;
>

\
 
 \ /
  Last update: 2024-05-27 15:57    [W:0.145 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site