lkml.org 
[lkml]   [2024]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v3 10/17] dt-bindings: net: pse-pd: Add another way of describing several PSE PIs

    On Thu, 08 Feb 2024 14:08:47 +0100, Kory Maincent wrote:
    > Before hand we set "#pse-cell" to 1 to define a PSE controller with
    > several PIs (Power Interface). The drawback of this was that we could not
    > have any information on the PI except its number.
    > Add support for pse_pis and pse_pi node to be able to have more information
    > on the PI like the number of pairset used and the pairset pinout.
    >
    > Sponsored-by: Dent Project <dentproject@linuxfoundation.org>
    > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
    > ---
    >
    > Changes in v3:
    > - New patch
    > ---
    > .../bindings/net/pse-pd/pse-controller.yaml | 101 ++++++++++++++++++++-
    > 1 file changed, 98 insertions(+), 3 deletions(-)
    >

    My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
    on your patch (DT_CHECKER_FLAGS is new in v5.13):

    yamllint warnings/errors:
    /Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml:80:13: [warning] wrong indentation: expected 14 but found 12 (indentation)
    /Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml:80:15: [error] string value is redundantly quoted with any quotes (quoted-strings)
    /Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml:81:15: [error] string value is redundantly quoted with any quotes (quoted-strings)

    dtschema/dtc warnings/errors:
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml: $defs:pse_pi:properties:pairset-names: {'description': 'Names of the pairsets as per IEEE 802.3-2022, Section 145.2.4. Valid values are "alternative-a" and "alternative-b". Each name should correspond to a phandle in the \'pairset\' property pointing to the power supply for that pairset.', '$ref': '/schemas/types.yaml#/definitions/string-array', 'minItems': 1, 'maxItems': 2, 'items': [{'enum': ['alternative-a', 'alternative-b']}]} should not be valid under {'required': ['maxItems']}
    hint: "maxItems" is not needed with an "items" list
    from schema $id: http://devicetree.org/meta-schemas/items.yaml#
    /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml: $defs:pse_pi:properties:pairset-names: 'oneOf' conditional failed, one must be fixed:
    [{'enum': ['alternative-a', 'alternative-b']}] is too short
    False schema does not allow 1
    hint: "minItems" is only needed if less than the "items" list length
    from schema $id: http://devicetree.org/meta-schemas/items.yaml#

    doc reference errors (make refcheckdocs):

    See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240208-feature_poe-v3-10-531d2674469e@bootlin.com

    The base for the series is generally the latest rc1. A different dependency
    should be noted in *this* patch.

    If you already ran 'make dt_binding_check' and didn't see the above
    error(s), then make sure 'yamllint' is installed and dt-schema is up to
    date:

    pip3 install dtschema --upgrade

    Please check and re-submit after running the above command yourself. Note
    that DT_SCHEMA_FILES can be set to your schema file to speed up checking
    your schema. However, it must be unset to test all examples with your schema.


    \
     
     \ /
      Last update: 2024-05-27 14:54    [W:4.312 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site