Messages in this thread | | | Date | Thu, 8 Feb 2024 21:10:25 +1030 | Subject | Re: [PATCH v6 2/5] dt-bindings: iio: light: adps9300: Add property vdd-supply | From | Subhajit Ghosh <> |
| |
Hi Krzysztof,
On 8/2/24 18:47, Krzysztof Kozlowski wrote: > On 06/02/2024 14:00, Subhajit Ghosh wrote: >> Add vdd-supply property which is valid and useful for all the >> devices in this schema. > > Why is it useful? How is it useful? DT describes the hardware, not > because something is "useful". I am adding this property based on a previous review: https://lore.kernel.org/all/20240121153655.5f734180@jic23-huawei/
Does the below commit message in this context make sense to you? "Add vdd-supply property for all the devices in this schema." > >> >> this patch depends on patch: >> "dt-bindings: iio: light: Merge APDS9300 and APDS9960 schemas" > > This is unrelated and does not make any sense in commit msg. Drop. Apologies for the silly questions: What does the "Drop" signify? Are you asking me to drop/delete the above "...patch depends..." message or does it have any other meaning?
In the next version, do I include the ack tag by Conor for this commit? > > > Best regards, > Krzysztof > Thank you for reviewing. Regards, Subhajit Ghosh
| |