lkml.org 
[lkml]   [2024]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v3 16/24] gpio: sysfs: don't access gdev->chip if it's not needed
Date
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Don't dereference gdev->chip if the same information can be obtained
from struct gpio_device.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/gpio/gpiolib-sysfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c
index b46d50ac2452..2e3edf41e853 100644
--- a/drivers/gpio/gpiolib-sysfs.c
+++ b/drivers/gpio/gpiolib-sysfs.c
@@ -403,7 +403,7 @@ static ssize_t base_show(struct device *dev,
{
const struct gpio_device *gdev = dev_get_drvdata(dev);

- return sysfs_emit(buf, "%d\n", gdev->chip->base);
+ return sysfs_emit(buf, "%d\n", gdev->base);
}
static DEVICE_ATTR_RO(base);

@@ -412,7 +412,7 @@ static ssize_t label_show(struct device *dev,
{
const struct gpio_device *gdev = dev_get_drvdata(dev);

- return sysfs_emit(buf, "%s\n", gdev->chip->label ?: "");
+ return sysfs_emit(buf, "%s\n", gdev->label);
}
static DEVICE_ATTR_RO(label);

@@ -421,7 +421,7 @@ static ssize_t ngpio_show(struct device *dev,
{
const struct gpio_device *gdev = dev_get_drvdata(dev);

- return sysfs_emit(buf, "%u\n", gdev->chip->ngpio);
+ return sysfs_emit(buf, "%u\n", gdev->ngpio);
}
static DEVICE_ATTR_RO(ngpio);

--
2.40.1

\
 
 \ /
  Last update: 2024-05-27 14:54    [W:0.755 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site