Messages in this thread | | | Date | Thu, 8 Feb 2024 00:39:01 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: ethernet: remove duplicated CONFIG_SUNGEM_PHY entry |
| |
On Tue, Feb 06, 2024 at 05:41:30PM +0000, Simon Horman wrote: > On Sun, Feb 04, 2024 at 09:31:51PM +0900, Masahiro Yamada wrote: > > Both drivers/net/Kconfig and drivers/net/ethernet/Kconfig contain the > > same config entry: > > > > config SUNGEM_PHY > > tristate > > > > Commit f860b0522f65 ("drivers/net: Kconfig and Makefile cleanup") moved > > SUNGEM_PHY from drivers/net/Kconfig to drivers/net/ethernet/Kconfig. > > > > Shortly after it was applied, commit 19e2f6fe9601 ("net: Fix sungem_phy > > sharing.") added the second one to drivers/net/Kconfig. > > > > I kept the one in drivers/net/Kconfig because this CONFIG option controls > > the compilation of drivers/net/sungem_phy.c. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > Thanks Yamada-san, > > This looks good to me as-is, > but I guess a follow-up question is if sungem_phy.c > should move to drivers/net/phy.
It is not a phylib PHY driver. So i would say no.
It would however be nice to port the MAC drivers using this to phylib. The PHY devices this sungem_phy.c supports don't look particularly exotic, just Marvell and Broadcom PHYs which phylib probably already supports.
Andrew
| |