lkml.org 
[lkml]   [2024]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP from ethtool
Hello Jakub-san, and all reviewers and maintainers,

It has been a week since I last received any feedback on this patch. I
apologize for the inconvenience during this busy period, but I would
greatly appreciate it if you could continue the review.

Sincerely,
Takeru

2024年2月1日(木) 9:59 takeru hayasaka <hayatake396@gmail.com>:
>
> Hi Jakub-san
> Thank you for your review.
> I apologize for the delay in resubmitting the patch.
>
> > Could you split the uAPI changes and the driver changes to two separate
> > commits? You should post them as a patch series, but combining them
> > into a single commit makes the uAPI addition to easy to miss.
>
> Understood. I will split the patches and submit them separately in v7.
>
> Thanks
> Takeru
>
> 2024年2月1日(木) 6:13 Jakub Kicinski <kuba@kernel.org>:
> >
> > On Wed, 31 Jan 2024 13:46:22 +0000 Takeru Hayasaka wrote:
> > > .../device_drivers/ethernet/intel/ice.rst | 21 ++++-
> > > drivers/net/ethernet/intel/ice/ice_ethtool.c | 82 +++++++++++++++++++
> > > drivers/net/ethernet/intel/ice/ice_flow.h | 31 +++++--
> > > drivers/net/ethernet/intel/ice/ice_lib.c | 37 +++++++++
> > > include/uapi/linux/ethtool.h | 48 +++++++++++
> >
> > Could you split the uAPI changes and the driver changes to two separate
> > commits? You should post them as a patch series, but combining them
> > into a single commit makes the uAPI addition to easy to miss.
> > --
> > pw-bot: cr

\
 
 \ /
  Last update: 2024-05-27 14:54    [W:0.073 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site