Messages in this thread | | | Date | Thu, 8 Feb 2024 17:04:52 -0500 | Subject | Re: [PATCH v4 01/12] nvdimm/pmem: Fix leak on dax_add_host() failure | From | Mathieu Desnoyers <> |
| |
On 2024-02-08 16:21, Andrew Morton wrote: > On Thu, 8 Feb 2024 13:49:02 -0500 Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote: > >> Fix a leak on dax_add_host() error, where "goto out_cleanup_dax" is done >> before setting pmem->dax_dev, which therefore issues the two following >> calls on NULL pointers: >> >> out_cleanup_dax: >> kill_dax(pmem->dax_dev); >> put_dax(pmem->dax_dev); > > Seems inappropriate that this fix is within this patch series? > > otoh I assume dax_add_host() has never failed so it doesn't matter much. > > > The series seems useful but is at v4 without much sign of review > activity. I think I'll take silence as assent and shall slam it all > into -next and see who shouts at me. >
Thanks Andrew for picking it up! Dan just reacted with feedback that will help reducing the patch series size by removing intermediate commits. I'll implement the requested changes and post a v5 in a few days.
So far there are not behavior changes requested in Dan's feedback.
Should I keep this patch 01/12 within the series for v5 or should I send it separately ?
Thanks,
Mathieu
-- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com
| |