lkml.org 
[lkml]   [2024]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] dt-bindings: pci: layerscape-pci: Convert to yaml file
On Thu, Feb 08, 2024 at 03:20:50PM -0500, Frank Li wrote:

> > > > > > > + reg:
> > > > > > > + maxItems: 2
> > > > > > > +
> > > > > > > + reg-names:
> > > > > > > + items:
> > > > > > > + - const: regs
> > > > > > > + - const: addr_space
> > > > > >
> > > > > > The example uses "regs" and "config". Where did addr_space come from?
> > > > >
> > > > > Example just show pcie-host part. Not show pcie-ep part.
> > > > > pcie-ep part need 'addr_space'.
> > > >
> > > > Okay. Again, please mention where this is coming from.
> > >
> > > Ideally it comes from snsp,dwc-pcie-ep.yaml. but it is use 'dbi' instead
> > > of 'regs'. It needs extra effort to make driver code algin common
> > > snps,dwc-pcie-ep.yaml, and update exist all dts files.
> > >
> > > I think it will be deleted soon.
> >
> > What I am looking for here is you to explain in the commit message that
> > the endpoint driver in linux and the dts have always used "addr_space".
> > Checking that there's not a u-boot or *bsd that uses "config" would also
> > be very helpful.
>
> I confused. Actually this two part PCIE-RC and PCIE-EP.
> PCIE-RC using 'config'
> PCIE-EP using 'addr_spcae'

Yeah, I get this. The text binding makes it seem like "config" should be
used for both RC and EP, so I am just asking you to check that there are
no drivers in other kernels or bootloaders that use "config" for EP
mode.

> I check old txt file, which have not mention it. I can remove it.

if you drop "addr_space", you'll need to update the endpoint driver so
that it supports both "addr_space" and "config". If there are no
endpoint drivers using "config" in other operating systems, and all the
dts files use "addr_space", documenting "reg" and "addr_space" for
endpoint mode seems fair to me.

Thanks,
Conor.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2024-05-27 14:55    [W:3.379 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site