lkml.org 
[lkml]   [2024]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] dma-coherent: add support for multi coherent rmems per dev
On Mon, Feb 05, 2024 at 02:08:00PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 05, 2024 at 07:23:00AM +0000, Howard Yen wrote:

..

> > @@ -18,15 +18,9 @@ struct dma_coherent_mem {
> > unsigned long *bitmap;
> > spinlock_t spinlock;
> > bool use_dev_dma_pfn_offset;
> > + struct list_head node;
>
> Have you run `pahole`? Here I see wasted bytes for nothing.

On top of that one may make container_of() to be no-op, by placing this member
to be the first one. But, double check this with bloat-o-meter (that it indeed
does better code generation) and on the other hand check if the current first
member is not performance critical and having additional pointer arithmetics is
okay.

> > };


--
With Best Regards,
Andy Shevchenko



\
 
 \ /
  Last update: 2024-05-27 14:50    [W:1.321 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site