Messages in this thread | | | Date | Tue, 6 Feb 2024 16:24:11 +0100 | Subject | Re: [PATCH v4 9/9] drm/mediatek: dsi: Use mipi_dsi_pixel_format_to_bpp() helper function | From | Alexandre Mergnat <> |
| |
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
On 06/02/2024 13:07, AngeloGioacchino Del Regno wrote: > Instead of open coding, use the mipi_dsi_pixel_format_to_bpp() helper > function from drm_mipi_dsi.h in mtk_dsi_poweron() and for validation > in mtk_dsi_bridge_mode_valid(). > > Note that this function changes the behavior of this driver: previously, > in case of unknown formats, it would (wrongly) assume that it should > account for a 24-bits format - now it will return an error and refuse > to set clocks and/or enable the DSI. > > This is done because setting the wrong data rate will only produce a > garbage output that the display will misinterpret both because this > driver doesn't actually provide any extra-spec format support and/or > because the data rate (hence, the HS clock) will be wrong.
-- Regards, Alexandre
| |