Messages in this thread | | | Date | Tue, 6 Feb 2024 15:25:33 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH 7/8] net: intel: igb: Use linkmode helpers for EEE |
| |
> > - adv100m_eee = !!(edata->advertised_u32 & ADVERTISE_100_FULL); > > - adv1g_eee = !!(edata->advertised_u32 & ADVERTISE_1000_FULL); > > + adv100m_eee = linkmode_test_bit( > > + ETHTOOL_LINK_MODE_100baseT_Full_BIT, > > + edata->advertised); > > + adv1g_eee = linkmode_test_bit( > > + ETHTOOL_LINK_MODE_100baseT_Full_BIT, > > Probably a typo, I think it should be ETHTOOL_LINK_MODE_1000baseT_Full_BIT > here :)
Yes, good catch. Thanks.
Andrew
--- pw-bot: cr
| |