Messages in this thread | | | From | Valentin Schneider <> | Subject | Re: [PATCH v3 2/3] sched/fair: Do strict inequality check for busiest misfit task group | Date | Tue, 06 Feb 2024 14:17:22 +0100 |
| |
On 05/02/24 22:39, David Vernet wrote: > In update_sd_pick_busiest(), when comparing two sched groups that are > both of type group_misfit_task, we currently consider the new group as > busier than the current busiest group even if the new group has the > same misfit task load as the current busiest group. We can avoid some > unnecessary writes if we instead only consider the newest group to be > the busiest if it has a higher load than the current busiest. This > matches the behavior of other group types where we compare load, such as > two groups that are both overloaded. > > Let's update the group_misfit_task type comparison to also only update > the busiest group in the event of strict inequality. > > Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
| |