lkml.org 
[lkml]   [2024]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH][next] comedi: remove redundant assignment to variable range
From
On 05/02/2024 18:04, Colin Ian King wrote:
> The variable range is being initialized with a value that is never
> read, it is being re-assigned later on. The initialization is
> redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/comedi/drivers/das08.c:180:2: warning: Value stored
> to 'range' is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/comedi/drivers/das08.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/comedi/drivers/das08.c b/drivers/comedi/drivers/das08.c
> index 5d5b9174f88a..49944ce1f813 100644
> --- a/drivers/comedi/drivers/das08.c
> +++ b/drivers/comedi/drivers/das08.c
> @@ -177,7 +177,6 @@ static int das08_ai_insn_read(struct comedi_device *dev,
> int ret;
>
> chan = CR_CHAN(insn->chanspec);
> - range = CR_RANGE(insn->chanspec);
>
> /* clear crap */
> inb(dev->iobase + DAS08_AI_LSB_REG);

Thanks. It looks like it gets reassigned to the same value further
down, closer to the point where the value is used (within an `if`
block), and so it doesn't matter which of the assignments is removed.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company )=-
-=( registered in England & Wales. Regd. number: 02862268. )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-


\
 
 \ /
  Last update: 2024-05-27 14:50    [W:0.490 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site