lkml.org 
[lkml]   [2024]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net] netfilter: nf_tables: fix pointer math issue in nft_byteorder_eval()
On Tue, Feb 06, 2024 at 11:43:36AM +0100, Michal Kubecek wrote:
>
> I stumbled upon this when the issue got a CVE id (sigh) and I share
> Andrea's (Cc-ed) concern that the fix is incomplete. While the fix,
> commit c301f0981fdd ("netfilter: nf_tables: fix pointer math issue in
> nft_byteorder_eval()") now, fixes the destination side, src is still
> a pointer to u32, i.e. we are reading 64-bit values with relative
> offsets which are multiples of 32 bits.
>
> Shouldn't we fix this as well, e.g. like indicated below?
>

Yep. You're right. Could you send that as a patch.

regards,
dan carpenter


\
 
 \ /
  Last update: 2024-05-27 14:50    [W:0.105 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site