Messages in this thread | | | Date | Tue, 6 Feb 2024 14:25:50 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] mm/cma: Drop cma_get_name() |
| |
On Tue, 6 Feb 2024 09:45:18 +0530 Anshuman Khandual <anshuman.khandual@arm.com> wrote:
> cma_get_name() just returns cma->name without any additional transformation > unlike other helpers such as cma_get_base() and cma_get_size(). This helper > is not worth the additional indirection, and can be dropped after replacing > directly with cma->name in the sole caller __add_cma_heap().
drivers/dma-buf/heaps/cma_heap.c: In function '__add_cma_heap': drivers/dma-buf/heaps/cma_heap.c:379:28: error: invalid use of undefined type 'struct cma' 379 | exp_info.name = cma->name; | ^~
Fixing this would require moving the `struct cma' definition into cma.h. I don't think that's worthwhile.
| |