Messages in this thread | | | Date | Tue, 6 Feb 2024 09:37:32 -0800 | Subject | Re: [PATCH] regmap: kunit: fix raw noinc write test wrapping | From | Guenter Roeck <> |
| |
On 2/6/24 07:10, Ben Wolsieffer wrote: > The raw noinc write test places a known value in the register following > the noinc register to verify that it is not disturbed by the noinc > write. This test ensures this value is distinct by adding 100 to the > second element of the noinc write data. > > The regmap registers are 16-bit, while the test value is stored in an > unsigned int. Therefore, adding 100 may cause the register to wrap while > the test value does not, causing the test to fail. This patch fixes this > by changing val_test and val_last from unsigned int to u16. > > Signed-off-by: Ben Wolsieffer <ben.wolsieffer@hefring.com> > Reported-by: Guenter Roeck <linux@roeck-us.net> > Closes: https://lore.kernel.org/linux-kernel/745d3a11-15bc-48b6-84c8-c8761c943bed@roeck-us.net/T/
I no longer see the problem with this patch applied.
Tested-by: Guenter Roeck <linux@roeck-us.net>
Thanks, Guenter
| |