Messages in this thread | | | Date | Tue, 6 Feb 2024 09:24:27 -0800 | Subject | Re: [PATCH 4/5] drm/panel: simple: fix flags on RK043FN48H | From | Jessica Zhang <> |
| |
On 2/5/2024 1:06 AM, Raphael Gallais-Pou wrote: > DISPLAY_FLAGS_SYNC_POSEDGE is missing in the flags on the default > timings. When overriding the default mode with one described in the > device tree, the mode does not get acked because of this missing flag. > Moreover since the panel is driven by the positive edge it makes sense > to add it here. > > Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Hi Raphael,
Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Thanks,
Jessica Zhang
> --- > drivers/gpu/drm/panel/panel-simple.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 2214cb09678c..7b286382ffb4 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -3523,7 +3523,8 @@ static const struct display_timing rocktech_rk043fn48h_timing = { > .vfront_porch = { 1, 4, 4 }, > .vsync_len = { 1, 10, 10 }, > .flags = DISPLAY_FLAGS_VSYNC_LOW | DISPLAY_FLAGS_HSYNC_LOW | > - DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE, > + DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE | > + DISPLAY_FLAGS_SYNC_POSEDGE, > }; > > static const struct panel_desc rocktech_rk043fn48h = { > > -- > 2.25.1 >
| |