Messages in this thread | | | Date | Mon, 5 Feb 2024 15:41:52 +0100 | From | Vaibhav Gupta <> | Subject | Re: [PATCH] ipack: make ipack_bus_type const |
| |
On Sun, Feb 04, 2024 at 05:00:13PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the ipack_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> > --- > drivers/ipack/ipack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c > index b1471ba016a5..866bf48d803b 100644 > --- a/drivers/ipack/ipack.c > +++ b/drivers/ipack/ipack.c > @@ -187,7 +187,7 @@ static struct attribute *ipack_attrs[] = { > }; > ATTRIBUTE_GROUPS(ipack); > > -static struct bus_type ipack_bus_type = { > +static const struct bus_type ipack_bus_type = { > .name = "ipack", > .probe = ipack_bus_probe, > .match = ipack_bus_match, > > --- > base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7 > change-id: 20240204-bus_cleanup-ipack-7e502021db1f > > Best regards, > -- > Ricardo B. Marliere <ricardo@marliere.net> >
Hello Ricardo,
Thank you for your patch.
Acked-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Greg, would you please add it to your misc tree.
Thanks and regards, Vaibhav Gupta
| |