Messages in this thread | | | From | "Sa, Nuno" <> | Subject | RE: [PATCH v2 2/2] of: dynamic: flush devlinks workqueue before destroying the changeset | Date | Mon, 5 Feb 2024 13:10:33 +0000 |
| |
> -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Sent: Monday, February 5, 2024 1:36 PM > To: Sa, Nuno <Nuno.Sa@analog.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rafael J. Wysocki > <rafael@kernel.org>; Frank Rowand <frowand.list@gmail.com>; Rob Herring > <robh+dt@kernel.org>; Daniel Scally <djrscally@gmail.com>; Heikki Krogerus > <heikki.krogerus@linux.intel.com>; Sakari Ailus <sakari.ailus@linux.intelcom>; > Len Brown <lenb@kernel.org>; linux-acpi@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 2/2] of: dynamic: flush devlinks workqueue before > destroying the changeset > > [External] > > On Mon, Feb 05, 2024 at 01:09:33PM +0100, Nuno Sa via B4 Relay wrote: > > From: Nuno Sa <nuno.sa@analog.com> > > > > Device links will drop their supplier + consumer refcounts > > asynchronously. That means that the refcount of the of_node attached to > > these devices will also be dropped asynchronously and so we cannot > > guarantee the DT overlay assumption that the of_node refcount must be 1 in > > __of_changeset_entry_destroy(). > > > > Given the above, call the new fwnode_links_flush_queue() helper to flush > > the devlink workqueue so we can be sure that all links are dropped before > > doing the proper checks. > > Have you seen my comments against v1?
Hmm, not really. lei is not fetching any email (even this one - that's why I'm using my work email + awesome email client to reply). And looking directly in lore... I'm also not seeing any reply from you. Maybe there's an issue.
- Nuno Sá
| |