Messages in this thread | | | Date | Mon, 5 Feb 2024 18:05:02 +0800 | From | Peter Xu <> | Subject | Re: [PATCH v3] KVM: selftests: Fix the dirty_log_test semaphore imbalance |
| |
Shaoqin, Sean,
Apologies for a late comment. I'm trying to remember what I wrote..
On Fri, Feb 02, 2024 at 01:43:32AM -0500, Shaoqin Huang wrote: > Why sem_vcpu_cont and sem_vcpu_stop can be non-zero value? It's because > the dirty_ring_before_vcpu_join() execute the sem_post(&sem_vcpu_cont) > at the end of each dirty-ring test. It can cause two cases:
As a possible alternative, would it work if we simply reset all the sems for each run? Then we don't care about the leftovers. E.g. sem_destroy() at the end of run_test(), then always init to 0 at entry.
-- Peter Xu
| |