lkml.org 
[lkml]   [2024]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC] perf: Reconsider an error code selection in bpf_map__fprintf()
Hello,

On Thu, Feb 1, 2024 at 10:49 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > A null pointer check is performed for the input parameter “map”.
> > It looks suspicious that the function “PTR_ERR” is applied then for
> > a corresponding return statement.
>
> Are contributions also by YueHaibing still waiting on further development considerations?
>
> [PATCH -next] perf: Fix pass 0 to PTR_ERR
> https://lore.kernel.org/lkml/20220611040719.8160-1-yuehaibing@huawei.com/
> https://lkml.org/lkml/2022/6/11/3

I think we dropped the bpf-loader and it seems bpf_map.[ch] is
leftover. I don't see any users of bpf_map__fprintf() in the tree.
Maybe we can drop it too.

Thanks,
Namhyung

\
 
 \ /
  Last update: 2024-05-27 14:49    [W:0.075 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site