Messages in this thread | | | Date | Mon, 5 Feb 2024 09:21:11 +0200 | From | Tony Lindgren <> | Subject | Re: [PATCH v2 02/15] pinctrl: pinctrl-single: move suspend()/resume() callbacks to noirq |
| |
* Andi Shyti <andi.shyti@kernel.org> [240129 22:49]: > On Sat, Jan 27, 2024 at 11:31:11PM +0100, Linus Walleij wrote: > > On Fri, Jan 26, 2024 at 3:37 PM Thomas Richard > > <thomas.richard@bootlin.com> wrote: > > > > > The goal is to extend the active period of pinctrl. > > > Some devices may need active pinctrl after suspend() and/or before > > > resume(). > > > So move suspend()/resume() to suspend_noirq()/resume_noirq() in order to > > > have active pinctrl until suspend_noirq() (included), and from > > > resume_noirq() (included). > > > > > > The deprecated API has been removed to use the new one (dev_pm_ops struct). > > > > > > Signed-off-by: Thomas Richard <thomas.richard@bootlin.com> > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > > > Do you want to merge this as a series or is this something I > > should just apply? > > there is still a comment from me pending.
FYI I gave this a brief test and things seem to work fine for me. Sounds like there will be another revision though so I'll test again then.
Regards,
Tony
| |